Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 246fe2c: Fixup: tvb_* -> tvb_capt
Yeah, I figured backing it out would be easy enough but I wanted to
(re)start the conversation. I also wasn't sure if the question had been
discussed at Sharkfest (where a bunch of the core developers are now).
On 06/19/14 11:52, Dario Lombardo wrote:
I made the push before Evan's comment. My commit has already been
merged. If you think it is creating problems I suppose you can rebase
and get it out of the master.
On Thu, Jun 19, 2014 at 5:45 PM, Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> wrote:
On 06/18/14 10:14, Wireshark code review wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=246fe2ca4c67d8c98caa84e2f57694f6322e2f96
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
246fe2c by Dario Lombardo (lomato@xxxxxxxxx):
Fixup: tvb_* -> tvb_captured
[...]
epan/dissectors/packet-cast.c | 6 +-
... 544 lines suppressed ...
Hmm, as Evan said[1], I thought the reason these hadn't all been
mass-converted was because they were supposed to be manually reviewed to see
which of the new APIs were supposed to be used; this is especially true with
the tvb_length() API because it has been a very common mistake to use
tvb_length() when what was intended was tvb_reported_length().
[1] https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
