Wireshark · Wireshark-dev: Re: [Wireshark-dev] Gerrit versus Buildbot

[Bálint Réczey <balint@xxxxxxxxxxxxxxx>]

2014-03-21 22:24 GMT+01:00 Bálint Réczey <balint@xxxxxxxxxxxxxxx>:
> Hi,
>
> 2014-03-20 23:11 GMT-01:00 Guy Harris <guy@xxxxxxxxxxxx>:
>>
>> On Mar 20, 2014, at 2:24 PM, Chris Kilgour <techie@xxxxxxxxxxxxxxx> wrote:
>>
>>> On 03/20/2014 01:07 PM, Gerald Combs wrote:
>>>>
>>>> If the build system had open access what would keep someone from
>>>> uploading a shell script containing a box full of weasels wearing clown
>>>> shoes?
>>>
>>> Isn't the same thing true for Jenkins/buildbot spawned from gerrit?  Surely the build machines must be limited/sandboxed to prevent the circus from taking over the town.
>>
>> Currently, it's limited to building stuff to which at least one core developer is willing to give +2.  That requires human judgement, so it's not as rigid as a hardware/software-implemented sandbox.
> Could it please be changed to build changes having at least _+1_ from
> a Core Developer? +2 has the meaning that it is ready for submitting
> and using +1 for triggering build-bot would be handy.
I have just checked and +2 did not trigger a build. I have updated
http://wiki.wireshark.org/Development/Workflow accordingly.

Cheers,
Balint