Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: C

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

On Thu, Jan 2, 2014 at 8:18 PM, Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> wrote:

On 01/02/14 13:52, Alexis La Goutte wrote:

On Thu, Jan 2, 2014 at 7:12 PM, Joerg Mayer <jmayer@xxxxxxxxx

<mailto:jmayer@xxxxxxxxx>> wrote:

    On Thu, Jan 02, 2014 at 05:04:10PM +0000, alagoutte@xxxxxxxxxxxxx

    <mailto:alagoutte@wireshark.org> wrote:
     >
    http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54557
     >
     > User: alagoutte
     > Date: 2014/01/02 05:04 PM
     >
     > Log:
     >  Add About window for Wireshark Qt

    Great! Just some nitpicks:

Thanks !

    - The plugins list is empty (maybe something wrong with my setup?)

  No i have the some issue... (with Linux and Windows....)
(On my linux box, i have no plugin with wireshark gtk...)

I thought that this was a generic problem with cmake.  (It works in wireshark-gtk when compiled with autofoo.)

There is some strange stuff with About window... (Need to have installed Wireshark to have License (COPYING) or AUTHORS...

    - The authors list is not formatted

Ok, i will look !

I think this is a generic cmake problem too (it does not work with wireshark-gtk either).

not formatted or display ?

    - The release notes have not been updated

Yes, a mistake

- and crash on Windows...

... and when compiled with autofoo.  I fixed that in r54563 (at least for autofoo).

Thanks for the fix... i search to change cmake build... but don't found your tip !

 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe