Wireshark-dev: [Wireshark-dev] Changing isprint to g_ascii_print
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Sat, 21 Dec 2013 16:32:18 +0100
Hello,

I removed isprint.h file, and replaced all isprint() using this hack
to g_ascii_isprint().

I've also simplify: isascii && isprint() to g_ascii_isprint()

This changes seems correct, but please review.


Still we have lot of isprint() calls (some in Qt) which I
think should be using g_ascii_*() [1].

Please check.

Thanks,
Kuba.

[1] https://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-ascii-isalnum