Wireshark-dev: Re: [Wireshark-dev] Unused dissector tables
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 13:48:26 -0800
On Dec 12, 2013, at 9:03 AM, Gerald Combs <gerald@xxxxxxxxxxxxx> wrote:

> The following dissectors create dissector tables but don't appear to use
> them:
> 
> packet-fcp.c

It appears *never* to have used the dissector table.

In addition, the field in the dissector with the same name as the dissector table

	1) is a hidden field;

	2) was always being set to 0;

	3) doesn't appear to have been used for anything in the code;

and a quick look through NCITS 481-2011, Fibre Channel Protocol for SCSI, Fourth Version (FCP-4), doesn't indicate anything obvious that would be the "type" field in question.

I got rid of the dissector table and the field.