Wireshark-dev: Re: [Wireshark-dev] To display reserved fields or not display reserved fields, t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Edwin Groothuis <Edwin.Groothuis@xxxxxxxxxxxx>
Date: Mon, 9 Dec 2013 00:34:57 +0000

Hello,

 

Display it. You are writing a dissector which describes the data seen on the wire, not one which goes “You are not interested in this”.

 

Also, if there is something on the screen which says “Reserved” or a number of bits which say “Not in use” and there is a value in it, then you know that there has been some update in the protocol and that you need to update your dissector.

 

Edwin

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Kaul
Sent: Monday, 9 December 2013 02:54
To: Developer support list for Wireshark
Subject: [Wireshark-dev] To display reserved fields or not display reserved fields, that is the question...

 

Should I:

 

proto_tree_add_text(seg_param_tree, tvb, offset, 2, "reserved");

offset += 2;

 

or:

offset += 2; /* reserved */

 

What is better? (Regretully I'm working on SCSI, whose creators LOVED sprinkling reserved bytes everywhere!).

 

 

Do we have a standard? (perhaps worth having a global param for it?!).

Y.