Wireshark · Wireshark-dev: [Wireshark-dev] Build instability

[Kaul <mykaul@xxxxxxxxx>]

Hi all,

I've been trying to enhance a specific dissector for two weeks now.

Since I'm afraid of diverging the code (although I'm working on a specific dissector), I update my code base often (~ once a day). Regretfully, 5 times (in 2 weeks!) this has resulted in compilation failure.

I'm pretty sure (subjectively) this hasn't happened in the past. Any measures we can put (continuous build system?) in place to prevent this?

Today's failure (2nd failure only today btw):

make[5]: Entering directory `/home/yanivk/wireshark/epan/dissectors'

  CC       libdissectors_la-packet-ssl-utils.lo

packet-ssl-utils.c: In function 'ssl_keylog_parse_session_id':

packet-ssl-utils.c:4201:9: error: implicit declaration of function 'from_hex_char' [-Werror=implicit-function-declaration]

         if (from_hex_char(line[2*i]) != (ssl_session->session_id.data[i] >> 4) ||

         ^

packet-ssl-utils.c:4218:5: error: implicit declaration of function 'from_hex' [-Werror=implicit-function-declaration]

     if (!from_hex(&ssl_session->master_secret, line, len))

     ^

cc1: all warnings being treated as errors

make[5]: *** [libdissectors_la-packet-ssl-utils.lo] Error 1

Thanks,

Y.