Wireshark-dev: Re: [Wireshark-dev] Status Cmake Win32 support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 2 Dec 2013 14:26:33 -0800
On Dec 2, 2013, at 8:14 AM, Joerg Mayer <jmayer@xxxxxxxxx> wrote:

> On Mon, Dec 02, 2013 at 02:28:43PM +0000, Graham Bloice wrote:
>> 
>> In the main CMakeLists.txt:
>> 
>> W:\Wireshark\trunk>c:\cygwin\bin\grep.exe -ni WTAP_PLUGIN_SOURCES *.txt
>> CMakeLists.txt:751:set(WTAP_PLUGIN_SOURCES
>> CMakeLists.txt:1061:            ${WTAP_PLUGIN_SOURCES}
>> CMakeLists.txt:1080:            ${WTAP_PLUGIN_SOURCES}
>> CMakeLists.txt:1100:            ${WTAP_PLUGIN_SOURCES}
>> CMakeLists.txt:1118:            ${WTAP_PLUGIN_SOURCES}
> 
> I just checked: This got removed by commit 53710 - so I possibly had that
> problem before as well.
> ------------------------------------------------------------------------
> r53710 | guy | 2013-12-02 09:30:29 +0100 (Mo, 02 Dez 2013) | 9 lines
> 
> Move most of the plugin code from epan to wsutil and remove all
> knowledge of particular types of plugins.  Instead, let particular types
> of plugins register with the common plugin code, giving a name and a
> routine to recognize that type of plugin.
> 
> In particular applications, only process the relevant plugin types.
> 
> Add a Makefile.common to the codecs directory.

Yes, WTAP_PLUGIN_SOURCES was a hack, and that change eliminated the need for it (and eliminated it).