Wireshark · Wireshark-dev: Re: [Wireshark-dev] SI vs. IEC prefixes

[Christopher Maynard <Christopher.Maynard@xxxxxxxxx>]

Christopher Maynard <Christopher.Maynard@...> writes:

> Joerg Mayer <jmayer <at> ...> writes:
> 
> > > What do others think before I make any changes to SI units?
> > 
> > Please change to SI in these cases.
> 
> So you're recommending moving to SI prefixes for both the file size autostop
> condition and the capture buffer size, or just the file size?  I just wanted
> to confirm because I gather from Evan's response that only the file size
> should be changed.  Concerning the capture buffer size, I'm fine either way,
> but if we don't change it to SI, then I'll change the units from MB -> MiB.

There was definitely consensus on the file size change from IEC -> SI, so I
committed that change in r53728.  And for now I just documented the capture
buffer size as "MiB" since that's the correct units.  I have no problem
changing the implementation of the capture buffer size to SI units though,
if anyone thinks it makes more sense to do that.  r53728 is scheduled for
1.10, but I decided to leave 1.8 alone.