Wireshark-dev: [Wireshark-dev] offset incrementation in packet-ssl.c (was: r53416: Add status_r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Wed, 20 Nov 2013 00:08:22 +0100
Hello Alexis, Peter,

Looking at r53416 [1] diff, I found two things in packet-ssl.c strange


2861 dissect_ssl3_hnd_hello_ext_status_request_v2(tvbuff_t *tvb, proto_tree *tree,

2869     while (list_len-- > 0)
2870         offset += dissect_ssl3_hnd_hello_ext_status_request(tvb, tree, offset, TRUE);

// but dissect_ssl3_ocsp_response() return offset not delta.


3929 dissect_ssl3_hnd_cert_status(tvbuff_t *tvb, proto_tree *tree,

3950             while (list_len-- > 0)
3951                 offset += dissect_ssl3_ocsp_response(tvb, tree, offset, pinfo);

// but dissect_ssl3_ocsp_response() return offset not delta.


I think in both cases it should be '=' not '+='

Could you please check it?
Thanks,

Kuba.

[1] http://code.wireshark.org/git/?p=wireshark;a=commitdiff;h=123e3d92039770c0a36c4be97ae34c1ef27c4f8e