Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 51407: / /trunk/tools/: convert-prot
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Mon, 9 Sep 2013 17:45:09 +0200
Jakub,

On Sat, Aug 17, 2013 at 07:35:01PM +0000, darkjames@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51407
> 
> User: darkjames
> Date: 2013/08/17 12:35 PM
> 
> Log:
>  Commit far from being perfect conversation tool from hfindex to hfinfo.
> 
> Directory: /trunk/tools/
>   Changes    Path                          Action
>   +89 -0     convert-proto-tree-new.awk    Added

I just wanted to get familiar with the new hf_ stuff and tried the script on the
doc/packet-PROTOABBREV.c and I got at least one thing that doesn't look right:
The code of the converted file contains "THIS_HF_INIT =", which should probably
be "HFI_PROTOABBREV ="?
The #define gets added at the very beginning of the file instead of after the
initial comment(s) section.
Are there any other things that are incorrect / not good?

Thanks
    Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.