Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 51775: /trunk/tools/ /trunk/tools/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Thu, 5 Sep 2013 10:21:51 +0200
On Thu, Sep 05, 2013 at 10:01:51AM +0200, Stig Bjørlykke wrote:
> On Thu, Sep 5, 2013 at 9:38 AM, <jmayer@xxxxxxxxxxxxx> wrote:
> 
> >  Adapt generated output to always print paths relative to
> >  the asn1/<proto>/ subdir. This makes cmake generated builds
> >  look identical to autotools generated builds.
> >
> 
> 1. You are using TAB as indent, which does not always work very well.

Hmm, ok, this will be fixed in the commit for the "real" bug.
If there are whitespacerequirements, how about adding modelines?

> 2. I get this diff for all generated files when doing make in asn1
> (automake):
> 
> -/* ../../tools/asn2wrs.py -b -p cmp -c ./cmp.cnf -s ./packet-cmp-template
> -D . -O ../../epan/dissectors CMP.asn */
> +/* ..../../tools/asn2wrs.py -b -p cmp -c ./cmp.cnf -s
> ./packet-cmp-template -D . -O ..../../epan/dissectors CMP.asn */

Umm, yes. Thanks for your report. Absolute paths are those that begin
with / not all those that somewhere contain a /.

I will commit a fix shortly.

Ciao
  Jörg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.