Wireshark · Wireshark-dev: Re: [Wireshark-dev] Remove hf_ variables

[Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>]

Hi,

On Wed, Aug 07, 2013 at 09:57:36AM -0400, Jeff Morriss wrote:
> On 07/29/13 16:12, Jakub Zawadzki wrote:
> > There's no real need of them, and we can just replace them with
> > header_field_info structure.
> 
> Just for completeness one should mention that replacing the hf_ 
> variables with pointers means that each proto_tree_add_xxx() call will 
> be pushing 8 bytes (in what is hopefully by now the common case ;-)) 
> instead of 4 bytes onto the stack.

Luckily on x64 windows first 4 arguments (integers or pointers) are passed by registers
(rest of the world - 6). In either case hfinfo won't be passed by stack ;-)
(source: http://en.wikipedia.org/wiki/X86_calling_conventions#Microsoft_x64_calling_convention)