Wireshark-dev: Re: [Wireshark-dev] addr_resolv.c, transport name resolution appalingly slow.
Hi,
Another fix needed:
Index: epan/addr_resolv.c
===================================================================
--- epan/addr_resolv.c (revision 2122)
+++ epan/addr_resolv.c (working copy)
@@ -1763,7 +1763,9 @@
if( tp == NULL ) {
tp = eth_hash_new_entry(addr, resolve);
} else {
- eth_addr_resolve(tp); /* Found but needs to be resolved */
+ if (resolve && (tp->status == HASHETHER_STATUS_UNRESOLVED)){
+ eth_addr_resolve(tp); /* Found but needs to be resolved */
+ }
}
return tp;
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman
Sent: den 6 augusti 2013 17:28
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] addr_resolv.c, transport name resolution appalingly slow.
Hi,
This patch fixes it...
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman
Sent: den 6 augusti 2013 16:05
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] addr_resolv.c, transport name resolution appalingly slow.
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Evan Huus
Sent: den 6 augusti 2013 16:01
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] addr_resolv.c, transport name resolution appalingly slow.
On Tue, Aug 6, 2013 at 9:41 AM, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:
>> Hi,
>>
>> I will revert the change to use a hash table for transport name
>> resolution as soon as I can, the performance is horrible.
>
>It shouldn't be, glib hash tables are pretty efficient. If you profile, where is the time being spent?
Can't profile it just now...
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
