Wireshark · Wireshark-dev: Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

[Marc Petit-Huguenin <marc@xxxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 06/28/2013 07:21 AM, Jeff Morriss wrote:
> On 06/22/13 06:47, Bálint Réczey wrote:
>> Hi All,
>> 
>> 2013/6/21 Marc Petit-Huguenin <marc@xxxxxxxxxxxxxxxxxx>:
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>>> 
>>> On 06/20/2013 04:52 PM, Guy Harris wrote:
>>>> 
>>>> On Jun 20, 2013, at 2:58 PM, Marc Petit-Huguenin
>>>> <marc@xxxxxxxxxxxxxxxxxx> wrote:
>>>> 
>>>>> On 06/20/2013 02:17 PM, Gerald Combs wrote:
>>>>> 
>>>>>> Advantates: - I'm not sure that an in-house equivalent (e.g.
>>>>>> Gerrit plus a private repository) would be better than what
>>>>>> Github offers.
>>>>> 
>>>>> Yes, Gerrit is better than github:
>>>> 
>>>> Presumably you mean "Gerrit plus a private repository is better than 
>>>> github", as Gerrit, as far as I can tell, is just software that works
>>>> with a Git repository.
>>> 
>>> Yes, although managing repositories being what Gerrit do, Gerrit
>>> without a least one repository would be a very boring application.
>> :-)
>> 
>> I have started describing a Gerrit based workflow which IMO would fit to
>> the project at http://wiki.wireshark.org/Development/Workflow . Please
>> check it and share your opinion.
> 
> It would probably be good to include how/where patch submitters would
> attach other attachments (e.g., sample captures) that go along with their
> patch (I spent a little time going through the Gerrit docs and didn't find
> anything like that).  (A large portion of the patches we accept need to
> have a corresponding test capture file before anyone will accept it.)
> 

Gerrit does not replace the bug tracker, in fact it complements it, so the
attachments would still be stored in the bug - unless they are used for
something useful for the build, like regression testing, in which case they
would be part of the patchset.

It is possible to configure Gerrit to link automatically to the Bugzilla bugs:

https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#_a_id_trackingid_a_section_trackingid

- -- 
Marc Petit-Huguenin
Email: marc@xxxxxxxxxxxxxxxxxx
Blog: http://blog.marc.petit-huguenin.org
Profile: http://www.linkedin.com/in/petithug
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRzaQ+AAoJECnERZXWan7EdTsQAL401aUUhnsOwHAijt8nTzHT
u+i8n4dvaVLzZNqyEAKe0enPmGaPIhw5BGdyZYfcObiI/ySzrD4/yb5LjY/pCLCu
bKOVR8IOI0FkJjp3JK2u2QeC3FbBve7u1XnlQXO8rIUAnHNETenHmK/2tXPB1Y4U
GjEvz40fhh+KVXEScWmQbetKRMmfBjuP3Ey3PI3EJ4hCs0Bjzg/1AVDLslOpX5Ie
/PfJGDHPiKiiYogRTbj7/y6/tcDUMzSgZUK9USRJW6dvRSakCq1pzLW/BsXLN4NQ
8eT32RTgL/3p36eqIMpiebscduzbtO7S5uyi5vEP5IILTVnULHLbQ3WUPWqz5cru
q/em1BVCiq3F7BlTvjMxYgReVRULcfycZVHHJpjskSTN9+rkSuXAJ627xXdnHfQZ
lL10BAjgsZEu9Ge4Fuy9g+SJu8QGWn55KKTRGIQmpwmg+ZwO2NZqhUjOZLq972Bo
h0aosHt2phLHqLI0KZ4uXeG4LrWl0FVDQJtx/SqTYCa4LjEN8x69ajXlel7sfv3X
I/JY+TnlRHt9KZdsxhDh4VdM2VVk+9Wx/KorfIxOrrNsjvNtpxDFPuuUbBf0ef4T
7bbZ7C9aUVfr5mYf1OopRrS5rKf+I/0onFo53twVvFk5KJfRon2SYWBITC/1yxi7
TThB/qobkT+v0lXunTzW
=oLuH
-----END PGP SIGNATURE-----