Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 50197: /trunk/epan/ /trunk/epan/: proto.c

[Evan Huus <eapache@xxxxxxxxx>]

On Thu, Jun 27, 2013 at 3:17 PM,  <darkjames@xxxxxxxxxxxxx> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50197
>
> User: darkjames
> Date: 2013/06/27 12:17 PM
>
> Log:
>  cleanup [u]int fill proto with value_string function
>
>  Create generic int/uint fill functions from hfinfo_[u]int_value_format.
>
>  XXX: to be honest I don't get it why if dev picked up BASE_DEC_HEX and has value string we're truncating it to BASE_DEC...

Nesting parentheses? If I recall correctly, BASE_DEC_HEX displays as
dec_val (hex_val), and value strings display as string (value). So if
you use the two together you get string (dec_val (hex_val)) which is a
bit odd. This is just a guess though, I didn't write that code.

> Directory: /trunk/epan/
>   Changes    Path          Action
>   +78 -119   proto.c       Modified
>
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe