Wireshark · Wireshark-dev: Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

[Marc Petit-Huguenin <marc@xxxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 06/22/2013 03:47 AM, Bálint Réczey wrote:
> Hi All,
> 
> 2013/6/21 Marc Petit-Huguenin <marc@xxxxxxxxxxxxxxxxxx>:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>> 
>> On 06/20/2013 04:52 PM, Guy Harris wrote:
>>> 
>>> On Jun 20, 2013, at 2:58 PM, Marc Petit-Huguenin
>>> <marc@xxxxxxxxxxxxxxxxxx> wrote:
>>> 
>>>> On 06/20/2013 02:17 PM, Gerald Combs wrote:
>>>> 
>>>>> Advantates: - I'm not sure that an in-house equivalent (e.g.
>>>>> Gerrit plus a private repository) would be better than what Github
>>>>> offers.
>>>> 
>>>> Yes, Gerrit is better than github:
>>> 
>>> Presumably you mean "Gerrit plus a private repository is better than 
>>> github", as Gerrit, as far as I can tell, is just software that works
>>> with a Git repository.
>> 
>> Yes, although managing repositories being what Gerrit do, Gerrit without
>> a least one repository would be a very boring application.
> :-)
> 
> I have started describing a Gerrit based workflow which IMO would fit to
> the project at http://wiki.wireshark.org/Development/Workflow . Please
> check it and share your opinion.
> 

"Code is building and tests are passing on all platforms. (Tests automatically
start when at least one Core Developer gives +1 or +2 to prevent overloading
or cracking the build servers.)"

Why do not build and test all patchsets submitted?  Is that a limitation of
the build servers?  Having Jenkins automatically verify your patchset is IMO
one of the nice feature of Gerrit, and it will lower the workload of core devs
if building and testing are done before they start looking at the patchset.

For people not familiar with the integration between Gerrit and Jenkins:

http://vimeo.com/20084957

- -- 
Marc Petit-Huguenin
Email: marc@xxxxxxxxxxxxxxxxxx
Blog: http://blog.marc.petit-huguenin.org
Profile: http://www.linkedin.com/in/petithug
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRxc7jAAoJECnERZXWan7EcvoP/RbMse9RCPwEHVuSe8zmCQcC
g8esGPykMTBkY13h8HWgMwU8KPYzIKIiRabyu6KdRkQLBT0EbtT7GwBbztQ9T0xZ
x6ciLGfrwzd0MWZbppgp75Lkg0M8dg1d/EcjWbCTLJ5WxHyTjx4LThfJfiinH79M
+bDgopEC7bOgZXaiL00b+2P3DYts6qxNPpWX6AGzrIQhasZM2nrcBFKQQ21Krvqy
nRoPXLXfsX2dLU82vmRKVRRcciyaKzaMaEqLJPSUCb+u5oBL2eoFO1oAH3cXMhjr
EytYAE6mJwRU39ESfA4w2qaRLMv+HzAtUIH352KF+b3w8Vi0nTj+YdJG6DLjqMhM
yg73MPINxu0hvH6SqIeUPYLZbiTmswuOD+l69zhbQcOrQwW0hNdB0B37zvhSLuRI
zgJX1WInc3SY5O/1Xy/lW+7oX13FIYfb4vCm71jIMuzztV+3tXG550d6r51qrAdm
Iqnu0leOo3jwdk/UvNsBDu8ZpEz+0y7dadXxZc1oU8wfOxxDL1kuUsD8Xhicegfr
fnFdWmrhJ7L+lyKAw13d1uvb8e0Ah19NffxKUP89YpA+oiU4f/fPjO0JlnHwi8s5
K+VRv0Tr2LIivoCLJDSdhINsQPy3sHNVXfIFuzz0ujW3i8HiJk2W8ikhemcvJIkN
NZyAox8DPhIr8zdld4q8
=zSRl
-----END PGP SIGNATURE-----