Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 49995: /trunk/ /trunk/: macosx-setup.sh

[Dirk Jagdmann <doj@xxxxxxxxx>]

> Very nice indeed! The only thing that should be done outside the script
> is setting -j 3: On some systems it is too much, on others it is too
> little. It should be set in the command line, not the script.

I could change it to something like:

if [ -z "$MAKE_BUILD_OPT" ] ; then
  MAKE_BUILD_OPT="-j 3"
fi

This way the user can set custom make options, but the script has a default.

-- 
---> Dirk Jagdmann
----> http://cubic.org/~doj
-----> http://llg.cubic.org