Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 49871: /trunk/ /trunk/epan/dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 10 Jun 2013 12:03:22 -0700
On Jun 10, 2013, at 11:55 AM, gerald@xxxxxxxxxxxxx wrote:

> tools/lemon/lemon.c: Fix an integer shortening issue. (CMake enables
> -Werror here but Autotools doesn't. Which is correct?)

That which causes more errors to be detected and fixed is correct.  I'd turn on -Werror in autotools for lemon, see what breaks, and fix it.

> epan/dissectors/dcerpc: idl2wrs isn't an installed executable in
> Autotools so don't make it one in CMake.

Ronnie said "nuke it":

	http://www.wireshark.org/lists/wireshark-dev/201306/msg00001.html

so should we just delete idl2wrs.c?