Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 49380: /trunk-1.8/ /trunk-1.8/epan/d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Evan Huus <eapache@xxxxxxxxx>
Date: Fri, 17 May 2013 12:37:29 -0400
On Fri, May 17, 2013 at 12:20 PM, <gerald@xxxxxxxxxxxxx> wrote:
   ------------------------------------------------------------------------
   r49379 | morriss | 2013-05-17 07:38:36 -0700 (Fri, 17 May 2013) | 7 lines
   Changed paths:
      M /trunk/epan/tvbuff.c

   As suggested by Jakub: don't ep_alloc buffers for TVBs, use g_malloc()'d
   memory with tvb-free-callback.

   Fixes one of the "read after free" warnings from Valgrind reported in
   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8197 and the one reported
   in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8653
   ------------------------------------------------------------------------

I don't think this one was necessary in 1.8, since it doesn't have Jakub's work on shrinking the ep scope that I remember, but it won't hurt.

Evan