Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 47064: /trunk/epan/ /trunk/epan/: CM
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 24 Apr 2013 00:49:38 +0200
On Mon, Apr 22, 2013 at 03:55:31PM -0400, Maynard, Chris wrote:
> I merely tried to make it consistent with nmake (see line 855 of http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/Makefile.common?revision=48773&view=markup), but if I've misinterpreted this, then I apologize.  Feel free to back out any changes that aren't correct.

In order to be consistent with autofoo, you will have to break compilation
for out-of-tree builds :-/
If you delete epan/dissectors/packet-ncp2222.c, then do an out-of-tree
build with autofoo, the build will fail:

make[5]: Entering directory `/home/jmayer/work/wireshark/build/autofoo/epan/dissectors'
make[5]: *** No rule to make target `../../../../svn/trunk/epan/dissectors/packet-ncp2222.c', needed by `libdissectors_la-packet-ncp2222.lo'.  Stop.
make[5]: Leaving directory `/home/jmayer/work/wireshark/build/autofoo/epan/dissectors'

So trying to mimic autofoo behavior does not look like the best of ideas.
IMO autofoo builds should mimic the (original) cmake behavior instead.

Ciao
      jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.