Wireshark-dev: Re: [Wireshark-dev] RFC: Any reason not to do this?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Anders Broman <a.broman@xxxxxxxxxxxx>
Date: Wed, 24 Apr 2013 00:04:48 +0200
Martin Mathieson skrev 2013-04-23 22:23:
In a profile, I was surprised to see that > 2.5% of time was spent calling dissect_sip_tcp_heur().  There are no SIP PDUs in the log.  HTTP was very similar.

Does the attached change look reasonable?  It does a quick check for the first character being printable before trying to extract the first line and check it for NULL characters.

Thanks,
Martin

Looks OK to me.
Regards
Anders

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe