Wireshark-dev: Re: [Wireshark-dev] -Wmissing-prototypes ??
From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Wed, 13 Mar 2013 09:20:21 +0000
Hi,
Actually I'm just looking to reduce the number of warnings , with 15000+ warnings it's impossible to see if there is anything that should be fixed in there.
If we don't care about the warnings perhaps we should turn them off. As a side effect getting rid of the C++ warnings gives the option of using C++ should we want to - not sure about that myself.
Regards
Anders

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Evan Huus
Sent: den 13 mars 2013 04:07
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] -Wmissing-prototypes ??

The C++ standard requires prototypes for all functions, so g++ replaces gcc's -Wmissing-prototypes with a mandatory compiler error. I assume that this was part of the C++ compatibility work that Anders has been doing recently.

Evan

On Tue, Mar 12, 2013 at 10:55 PM, Bill Meier <wmeier@xxxxxxxxxxx> wrote:
> Anders:
>
> Just out of curiosity, why are the prototypes in the following change 
> needed ?
>
>
> Or: maybe the real question is: why is -Wmissing_prototypes needed ?
>
> We already catch any .h files which are missing prototypes of global 
> functions because we use -Wimplicit-function-declaration (part of -Wall).
>
> So: what am i missing ?
>
> Bill
>
>
>
>>
>> User: etxrab
>> Date: 2013/03/12 04:09 PM
>>
>> Log:
>>   - [-Wmissing-prototypes]
>
> --- packet-aodv.c       (revision 48273)
> +++ packet-aodv.c       (revision 48274)
> @@ -50,6 +50,8 @@
>   *     (both of the above two are draft-perkins-manet-aodv6-01.txt, which
>   *     is from November 2000)
>   */
> +void proto_register_aodv(void);
> +void proto_reg_handoff_aodv(void);
>
>  #define INET6_ADDRLEN  16
>  #define UDP_PORT_AODV  654
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe