Wireshark · Wireshark-dev: Re: [Wireshark-dev] A very minor Q re checkAPIs '"name for hf... has trailing space ...' error check

[Evan Huus <eapache@xxxxxxxxx>]

On Wed, Jan 30, 2013 at 6:38 PM, Bill Meier <wmeier@xxxxxxxxxxx> wrote:
> I've been doing a small update to checkAPIs.pl.
>
> Among other things: I changed the code to remove comments from the source
> code string before calling check_hf_entries() since the check doesn't detect
> an hf... entry if it contains a comment.
>
> I now get:
>
>  Error: the name for hf_ppi_vector_rot_x ("ppi_vector.pitch") has
>   trailing space in packet-ppi-vector.c
>
>  Error: the name for hf_ppi_vector_rot_y ("ppi_vector.roll") has
>   trailing space in packet-ppi-vector.c
>
>  Error: the name for hf_ppi_vector_rot_z ("ppi_vector.heading") has
>   trailing space in packet-ppi-vector.c
>
> Looking at packet-ppi-vector.c, I see:
>
>   { "Pitch   ", "ppi_vector.pitch", /*extra spaces intentional. casuses
> field values to align*/
> ...
>
> In fact, the field values do align when displayed.
>
>
> So: What to do ?
>
> My inclination would be just to remove the trailing spaces in the three
> names (labels) since it appears that it's felt that there should not be
> trailing spaces in field labels.
>
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548
>
> Thoughts ?

Agree that removing the trailing spaces is the right thing to do. If
we want fields to align (which would be nice, I admit) it should be
done in some dissector-agnostic way.

Evan