Wireshark · Wireshark-dev: Re: [Wireshark-dev] Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t)

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

Thanks a million Jeff. 

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jeff Morriss
Sent: den 29 november 2012 21:27
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t)

Anders Broman wrote:
> Hi,
> Any one up for the task? :-)
>  
> I recently ran in to a crash caused by a proprietary plug-in with the 
> above error.
> Packet-amr.c could be used for test.
> A check in prefs_dlg.c wouldn't hurt either...

checkAPIs change done in r46294 (along with, as I'm sure you saw, a check to ensure they're all const).

I'd shy away from a run-time check just to save (startup) cycles.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe