Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 46087: /trunk/ /trunk/: capture_opts
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Mon, 19 Nov 2012 16:32:53 -0500
Evan Huus wrote:
On Mon, Nov 19, 2012 at 4:00 PM, <morriss@xxxxxxxxxxxxx <mailto:morriss@xxxxxxxxxxxxx>> wrote: 

    http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46087
    <http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46087>

    User: morriss
    Date: 2012/11/19 01:00 PM

    Log:
     I'm pretty confident the string length will fit in 32 bits; cast
    away the "possible loss of data" warning on the Win64 build.

    Directory: /trunk/
      Changes    Path              Action
      +11 -11    capture_opts.c    Modified
Not that I really think the string is likely to exceed 2^32 characters, but wouldn't it be saner to declare prefix_length as a size_t instead? 

Yeah, you have a point. :-)  Fixed in r46088.