Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Sat, 3 Nov 2012 22:17:39 +0100
On Mon, Oct 08, 2012 at 01:12:50PM +0200, Jakub Zawadzki wrote:
> On Sun, Sep 30, 2012 at 06:32:26PM +0200, Jakub Zawadzki wrote:
> > If we want to have bug #6208 fixed in 1.x we need to revert r45189 + do:
> > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6208#c9
> > 
> > I'm not sure if I have time for writting such patch, but If anyone write one,
> > I can review.
> 
> Attaching patch for testing, still I have one XXX, to quote:
> 
> +  if (cf->count < frames_count && framenum <= cf->count) {
> +    /* XXX, what we should do when new frames were received during rescaning but user clicked abort?
> +     *   - call packet_list_append() for all new frames?
> +     *   - just warn user?
> +     */
> +  }

Ping?