Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/
Hi Evan,
I finally got around to applying/testing your patch on Windows XP SP3 32-bit. As expected, Wireshark continues to capture just fine.
The relevant code in gui_utils and tshark are very similar indeed, but there are some differences, so I'm not sure if they could be combined or not.
But as Guy pointed out in a subsequent response, perhaps pipes no longer need to be handled any differently on Windows anymore and we no longer need to wait for exit status? In truth, I haven't looked at this code too much and it's not really an area I'm too comfortable digging into right now.
- Chris
> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-
> bounces@xxxxxxxxxxxxx] On Behalf Of Evan Huus
> Sent: Monday, October 01, 2012 7:11 PM
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 45212:
> /trunk/ui/gtk/ /trunk/ui/gtk/: gui_utils.c
>
> On Sun, Sep 30, 2012 at 8:09 PM, Maynard, Chris
> <Christopher.Maynard@xxxxxxxxx> wrote:
> > Should similar changes be made here as well?
> >
> > capture_sync.c:1948: if (GetExitCodeProcess((HANDLE)
> capture_opts->fork_child, &childstatus) &&
> > tshark.c:1962: result1 =
> GetExitCodeProcess((HANDLE)*(pipe_input_p->child_process),
> >
> > - Chris
>
> The tshark code appears to be a copy of the one in gui_utils - I
> haven't looked too closely, but perhaps they should be deduplicated?
>
> The capture_sync code is interesting, since it treats the failure of
> GetExitCodeProcess as effectively an ignorable error. I don't know if
> that's indicative of best practice or it's simply another case of not
> knowing quite what to do with the return status. I don't have a problem
> with converting all three places for consistency, but without a Windows
> dev environment all I can really do is speculate.
>
> Evan
>
> Note to self: dig out old XP virtual machine and set it up for
> wireshark development
--
CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email. Thank you.
