Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 1 Oct 2012 16:43:21 -0700
On Sep 29, 2012, at 11:20 AM, "Maynard, Chris" <Christopher.Maynard@xxxxxxxxx> wrote:

> Good point Bill.  I hadn't actually looked too deeply here; I just wanted to appease the buildbot.  See: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/2646/steps/nmake%20all/logs/stdio
> 
> So maybe a minimal patch such as this is what is needed?  Maybe that was the original intent?
> - Chris
> 
> Index: ui/gtk/gui_utils.c

Just out of curiosity, given that we no longer support Windows OT (95, 98, Me), does the comment

    /* Tricky to use pipes in win9x, as no concept of wait.  NT can
       do this but that doesn't cover all win32 platforms.  GTK can do
       this but doesn't seem to work over processes.  Attempt to do
       something similar here, start a timer and check for data on every
       timeout. */

in pipe_input_set_handler() still apply, or can we now handle pipes on Windows the same way we do on UN*X?  If so, that would at least reduce the number of places where we need to ask for the exit status of a process.