Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/: packet.c

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/: pa

From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>

Date: Tue, 18 Sep 2012 21:43:38 +0200

On Tue, Sep 18, 2012 at 03:32:21PM -0400, Maynard, Chris wrote:
> Hmm, isn't this making an assumption about the dissector table?
> 
> dissector_add_uint() is used for more than just udp/tcp ports. 
> Couldn't there be perfectly valid cases of registering a value of 0 for other tables besides "udp.port", "tcp.port" and others like those?

Yes, and I've already revert it in r44980.

Cheers,
 Kuba.

References:
- Re: [Wireshark-dev] [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/: packet.c
  - From: Maynard, Chris

Prev by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 44860: /trunk/ /trunk/asn1/camel/: camel.cnf /trunk/asn1/charging_ase/: packet-charging_ase-template.c /trunk/asn1/cmp/: packet-cmp-template.c /trunk/asn1/credssp/: ...
Next by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 44860: /trunk/ /trunk/asn1/camel/: camel.cnf /trunk/asn1/charging_ase/: packet-charging_ase-template.c /trunk/asn1/cmp/: packet-cmp-template.c /trunk/asn1/credssp/: ...
Previous by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/: packet.c
Next by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 44860: /trunk/ /trunk/asn1/camel/: camel.cnf /trunk/asn1/charging_ase/: packet-charging_ase-template.c /trunk/asn1/cmp/: packet-cmp-template.c /trunk/asn1/credssp/: ...
Index(es):
- Date
- Thread