Wireshark · Wireshark-dev: Re: [Wireshark-dev] ep_ memory is not garbage collected

[Evan Huus <eapache@xxxxxxxxx>]

On Fri, Aug 17, 2012 at 10:02 AM, Jakub Zawadzki
<darkjames-ws@xxxxxxxxxxxx> wrote:
> On Thu, Aug 16, 2012 at 08:54:54PM -0400, Evan Huus wrote:
>> On Wed, Aug 15, 2012 at 11:36 AM, Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> wrote:
>> > From r43188 sequence of selecting new packet (cf_select_packet() in file.c) is:
>> >    cf_read_frame()
>> >    old_edt = cf->edt;
>> >    cf->edt = epan_dissect_new()                ; edt_refs++
>> >    epan_dissect_run(cf->edt, ...)
>> >    if (old_edt)
>> >      epan_dissect_free(old_edt);               ; edt_refs--  (edt_refs != 0, no gc)
>> >
>> > Old code was doing something like:
>> >    cf_read_frame()
>> >    epan_dissect_free(cf->edt);               ; edt_refs--    (likely edt_refs == 0, gc ep memory)
>> >    cf->edt = epan_dissect_new()              ; edt_refs++
>> >
>> > I have working fix for this, but check below.
>>
>> Based on the log for r43188 I expect there's someway to force clear
>> the GtkTreeStore, so that old_edt can be unrefed (triggering a gc)
>> before cf->edt is re-allocated?
>>
>> Is your fix checked in or attached to a bug somewhere?
>
> Attached, but it's more workaround than fix.

Looks sane enough as far as workarounds go. I don't know if there's
already a process for this, but I would commit that to trunk (with a
comment in the code pointing to this discussion). Once it's had a week
or two of soak time, backport it to 1.8 and remove it from trunk.

Any objections from the general list?

I'll try and take a look at a proper fix for trunk at some point, but
I've been very busy with real life lately, so no promises. I'm pretty
sure the stack idea from my previous email works if somebody else
wants to grab this.

Evan