Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 44480: /trunk/ui/gtk/ /trunk/ui/gtk/: CMakeLists.txt

[Gerald Combs <gerald@xxxxxxxxxxxxx>]

On 8/14/12 4:30 AM, Joerg Mayer wrote:
> On Tue, Aug 14, 2012 at 12:21:55AM +0000, gerald@xxxxxxxxxxxxx wrote:
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44480
>>
>> User: gerald
>> Date: 2012/08/13 05:21 PM
>>
>> Log:
>>  Comment out -DGDK_DISABLE_DEPRECATED to match configure.in.
>>
>> Directory: /trunk/ui/gtk/
>>   Changes    Path              Action
>>   +1 -1      CMakeLists.txt    Modified
> 
> I really think the patch should be the other way round - it should be enabled
> in configure.in as well. Otherwise this option is just a waste of storage and
> should be removed completely.

It probably should be enabled but right now it breaks compilation with
GTK 2.22 and 2.24:

ui/gtk/rlc_lte_graph.c: In function ‘create_drawing_area’:
ui/gtk/rlc_lte_graph.c:503: warning: implicit declaration of function
‘gdk_gc_new’
ui/gtk/rlc_lte_graph.c:503: warning: assignment makes pointer from
integer without a cast
ui/gtk/rlc_lte_graph.c:504: warning: implicit declaration of function
‘gdk_gc_set_function’
ui/gtk/rlc_lte_graph.c:519: warning: implicit declaration of function
‘gdk_gc_set_foreground’