Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 43908: /trunk/epan/dissectors/ /trun
Maybe just calling packet-data is the right way to go here?
ciao
Jörg
On Sun, Jul 22, 2012 at 04:44:17AM +0000, martinm@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43908
>
> User: martinm
> Date: 2012/07/21 09:44 PM
>
> Log:
> Calling tvb_format_text() for binary data segments (c1400 bytes) was
> *very* slow (in a profiled run where FTP data is carried over LTE
> MAC/RLC/PDCP/IP/TCP, this one function call was 20% of overall runtime).
>
> Have limited to call to ITEM_LABEL_LENGTH, as that is all that
> will be displayed anyway. As per comment, I'm not convinced that doing
> this for binary FTP data segments is worthwhile at all. It doesn't
> even display as hex.
>
> Directory: /trunk/epan/dissectors/
> Changes Path Action
> +6 -3 packet-ftp.c Modified
>
> ___________________________________________________________________________
> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
--
Joerg Mayer <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
