Wireshark · Wireshark-dev: Re: [Wireshark-dev] r43579 "Generic preference implementation" broken compile

[mmann78@xxxxxxxxxxxx]

Also, prefs_nameres.c shouldn't be building anymore.  The top of the tree should have it removed from any makefiles (unless I screwed up the patch).  The functionality of prefs_nameres.c was replaced with the generic handling of preferences that used to be unique to only protocol preferences.

 

-----Original Message-----
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Sent: Fri, Jul 6, 2012 1:59 pm
Subject: Re: [Wireshark-dev] r43579 "Generic preference implementation" broken compile

2012/7/6 Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx>

SVN revision 43579 broke compilation:

prefs_nameres.c: In function 'nameres_prefs_show':
prefs_nameres.c:109: error: 'e_prefs' has no member named 'name_resolve'
prefs_nameres.c:126: error: 'e_prefs' has no member named 'name_resolve'

This is one case of trying to use the variable that no longer exists:

        prefs.name_resolve = gbl_resolv_flags;

I haven't been following these changes recently - is this line still needed or is this a work in progress yet to be completed?

Hi Stephen,

give a try to current top of tree: it should compile.

Regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe