Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 43413: /trunk/ui/gtk/ /trunk/ui/gtk/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 20 Jun 2012 20:26:10 +0200
On Wed, Jun 20, 2012 at 05:35:38PM +0000, etxrab@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43413
> 
> User: etxrab
> Date: 2012/06/20 10:35 AM
> 
> Log:
>  #if 0 out code to make it build in it's current state
> 
> Directory: /trunk/ui/gtk/
>   Changes    Path                    Action
>   +3 -2      main_80211_toolbar.c    Modified

This of course caused another build failure (with warnings as errors)
due to now unused parameters.
Wouldn't it make more sense to comment the code back in
and add the changes to capture_sync.[hc] instead, thus avoiding the
missing function.

ciao
 Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.