Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 41216: /trunk/ /trunk/epan/dissectors/: packet-sctp.c /t

[Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>]

Jeff Morriss wrote:
> morriss@xxxxxxxxxxxxx wrote:
> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=41216
> >
> > User: morriss
> > Date: 2012/02/27 07:19 PM
> >
> > Log:
> >  Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 -
> >  make Save-As/Displayed/All-Packets save not only the displayed 
> > packets but
> >  also any other packets needed (e.g., for reassembly) to fully dissect 
> > the
> >  displayed packets.
> >  
> >  This works only for the "All packets" case; choosing only the 
> > Selected packet,
> >  the Marked packets, or a range of packets would require actually 
> > storing which
> >  packets depend on which (too much memory) or going through the packet 
> > list many
> >  times (too slow).  Also, this behavior is always the case: you can't 
> > save the
> >  displayed packets without their dependencies (I don't see why this 
> > would be
> >  desirable).
> >  
> >  So far this is done for SCTP and things using the reassembly routines 
> > (TCP has
> >  been tested).
> >  
> >  The Win32 dialog was modified but hasn't been tested yet.
> >  
> >  One confusing aspect of the UI is that the Displayed count in the 
> > Save-As
> >  dialog does not match the number of displayed packets.  (I tried 
> > renaming the
> >  button "Displayed + Dependencies" but it looked too big.)  The 
> > tooltip tries
> >  to explain this and the fact that this works only in the All-Packets 
> > case;
> >  suggestions for improvement are welcome.
>
> I thought of another way to implement this UI: basically to show the 
> count of Displayed packets followed by " (+N dependencies)" (if there 
> are any dependencies): see attached for an example.  Is this better?
>
> Only problem is that when I try this on Windows the "Packet Range" box 
> does not expand for the extra width so (using the sample sample capture) 
>  only "39 (+ 169" ends up being displayed.  Anyone know why that might 
> be and/or how to fix it?

Ah, okay, r42799 shows me how/where I could change the Win32 dialog 
(well, I didn't look in detail).  But I'm still not sure if it's a good 
idea.  Any thoughts?  (Screen shot attached again for reference.)