Wireshark-dev: Re: [Wireshark-dev] _U_ is used when it shouldn't be.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 30 Apr 2012 18:17:53 -0700
On Apr 30, 2012, at 6:08 PM, Christopher Maynard wrote:

> So after fixing a Clang warning, I noticed that _U_ is greatly overused in some
> files, such as packet-dcerpc-frsrpc.c, generated from epan/dissectors/pidl/.

Is _U_ being used in human-written code or in code written by the PIDL-to-dissector code?  If the latter, then it should be fixed in the generator *IF* the generator can, without too much trouble, figure out whether an argument is used; otherwise, it's probably not worth worrying about.