Wireshark-dev: Re: [Wireshark-dev] guint64 is a 'long' on 32-bit MacOS?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Thu, 01 Mar 2012 13:31:23 -0500
Michael Tuexen wrote:

On Mar 1, 2012, at 5:23 PM, Jeff Morriss wrote:


The 10.5-x86 and 10.5-ppc MacOS buildbots currently fail to compile the current SVN with these warnings:


packet-noe.c: In function 'decode_utf8':
packet-noe.c:805: warning: integer constant is too large for 'long' type
packet-noe.c:808: warning: integer constant is too large for 'long' type
packet-noe.c:814: warning: integer constant is too large for 'long' type
packet-noe.c:817: warning: integer constant is too large for 'long' type
packet-noe.c:818: warning: integer constant is too large for 'long' type

But the variables in question are guint64's (which should presumably be "long long"s on these 32-bit OS's, right?).

I guess that the problem is not the guint64 variable utf, but the constant 0xFFFFFFFFFF.
Does the attached patch fix the problem?


(For the record:) apparently, yes (Anders checked it in r41276).  Thanks!