Hi,
I get a warning(==eror) compiling the latest svn
[ 5%] Building C object
epan/CMakeFiles/epan.dir/dissectors/packet-mip.c.o
/home/martin/wireshark.svn/epan/dissectors/packet-mip.c:
In function 'dissect_mip_extensions':
/home/martin/wireshark.svn/epan/dissectors/packet-mip.c:424:11:
error: variable 'nvse_vendor_id' set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
It looks like this was introduced in r41171.
nvse_vendor_id is really not used, but the actual id is stored in an hf
and and added to the tree. Could we just remove nvse_vendor_id? Patch attached.
Best regards,
Martin
Index: epan/dissectors/packet-mip.c
===================================================================
--- epan/dissectors/packet-mip.c (revision 41173)
+++ epan/dissectors/packet-mip.c (working copy)
@@ -421,7 +421,6 @@
gint hdrLen;
guint32 cvse_vendor_id;
guint16 cvse_vendor_type;
- guint32 nvse_vendor_id;
guint16 nvse_vendor_type;
int cvse_local_offset= 0;
int nvse_local_offset= 0;
@@ -648,7 +647,6 @@
/*Vendor ID & nvse type & nvse value are included in ext_len, so do not increment offset for them here.*/
nvse_local_offset = offset + hdrLen;
proto_tree_add_item(ext_tree, hf_mip_nvse_vendor_org_id, tvb, nvse_local_offset, 4, ENC_BIG_ENDIAN);
- nvse_vendor_id = tvb_get_ntohl(tvb, nvse_local_offset);
nvse_local_offset+=4;
/*Vendor NVSE Type*/
