Wireshark-dev: [Wireshark-dev] Logical error in r37159
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Sean Bright <sean.bright@xxxxxxxxx>
Date: Thu, 09 Feb 2012 18:20:22 -0500
In r37159, the following change was made to ui/gtk/rtp_player.c:

 
@@ -1654,9 +1636,7 @@
 	GtkWidget *dialog;
 
 	/* we should never be here if we are in PLAY and !PAUSE */
-	if(!rtp_channels->stop && !rtp_channels->pause){
-		exit(10);
-	}
+	g_assert(!rtp_channels->stop && !rtp_channels->pause);


The logic, however, was not negated properly.  The correct assertion should be:

	g_assert(rtp_channels->stop || rtp_channels->pause);

With the current code, the RTP player causes a crash for me when pressing the 'Play' button.

Thanks,
Sean Bright