Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 40518: /trunk/ /trunk/epan/: plugins
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Sun, 15 Jan 2012 15:05:41 -0800
On Jan 15, 2012, at 1:59 PM, jmayer@xxxxxxxxxxxxx wrote:

> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40518
> 
> User: jmayer
> Date: 2012/01/15 01:59 PM
> 
> Log:
> Move gtk to ui/gtk.

Should those files in the top-level images directory that are only used by UI code be moved a ui/images directory?

A quick scan of the source finds a bunch of includes of XPM files from ui/gtk/*.c files; I'm guessing that they - the .xpm files - would only be used by UI code, making them candidates to be moved.

I'm not sure where the .png files are used - are they used as source to generate files such as ui/gtk/expert_indicators.h?  If so, they'd be candidates as well.  (And, if so, what tool is used to generate them?)

The same applies for expert_indicators.svg.

Should anything used only by packaging/installer tools be put into packaging/images or, if they're specific to a particular package type/installer, an images subdirectory or the top-level directory for that packaging/installer tool?