Wireshark · Wireshark-dev: Re: [Wireshark-dev] tap_queue_packet() simple question

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

On 2011-12-03 05:47, Chris Maynard wrote:

> Some taps, such as tap-comparestat.c and tap-rtp-common.c, make use 
> of
> pinfo->iphdrlen, so shouldn't tap_queue_packet() be called *after* 
> all
> the pinfo
> data is assigned by the dissector?
>
> I had already changed this to be the case for IPv4 (see line 2079), 
> but
> I just
> found the same thing in IPv6 (line 1976), so now I just want to be 
> sure
> I'm
> doing this right, or maybe there's some reason this wasn't being done
> for both
> of them? Thanks.
>
> - Chris

Hi,

This of course depends on what these taps listen to. Is it the 'ip' tap
(like probably for tap-comparestat.c), then yes. Is it the "rtp" tap
(probably for a user of tap-rtp-common.c) then no.

Thanks,
Jaap