Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c

[Michael Tüxen <Michael.Tuexen@xxxxxxxxxxxxxxxxx>]

On Nov 9, 2011, at 10:09 PM, Bill Meier wrote:

> On 11/9/2011 3:45 PM, stig@xxxxxxxxxxxxx wrote:
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39775
>> 
>> User: stig
>> Date: 2011/11/09 12:45 PM
>> 
>> Log:
>>  As reported by Michael Speck:
>>  Removed last occurrences of USE_THREADS.
>> 
>> Directory: /trunk/
>>   Changes    Path              Action
>>   +0 -4      CMakeLists.txt    Modified
>>   +1 -6      dumpcap.c         Modified
>> 
> Stig:
> 
> Any reason not to remove all the 'if (use_threads)' tests (just leaving the threads branches of the code) ??
dumpcap behaves differently if you capture from a single interface.
Without the -t flag, the program uses a single thread only. Using -t, you
have one reader thread for the interface and one thread writing the stuff
to disk. So I think it makes sense to leave the ifs in the dumpcap.c code.

Best regards
Michael
> 
> Bill
> 
> 
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>