Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38782: /trunk/gtk/ /trunk/gtk/: main
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Mon, 29 Aug 2011 22:09:01 +0200
On Mon, Aug 29, 2011 at 07:47:53PM +0000, sfisher@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38782
> 
> User: sfisher
> Date: 2011/08/29 12:47 PM
> 
> Log:
>  Fix compilation when compiling without libpcap (configure script parameter
>  "--without-pcap")
...  
>   Changes    Path              Action
>   +6 -2      main_menubar.c    Modified
>   +6 -0      stock_icons.c     Modified

Adding back to #ifdef HAVE_LIBPCAP is not the nicest way. We have way too
many places with #ifdef somethingorother. IIRC the intention of the patch
that caused the problem was to always have all features in the menu, some
of them just not visible/selectable(?).

Ciao
    Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.