Wireshark-dev: Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Gisle Vanem <gvanem@xxxxxxxxxxxx>
Date: Tue, 16 Aug 2011 20:05:29 +0200
"Stig Bjørlykke" <stig@xxxxxxxxxxxxx> wrote:


On Tue, Aug 16, 2011 at 12:17 AM, Gisle Vanem <gisle.vanem@xxxxxxxxx> wrote:

This:
#ifdef _MSC_VER
#define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm));
#endif

doesn't look so safe. We should maybe use the localtime_r() in
wsutil/strptime.c?


Or simply just use localtime, check the return value and then copy the values.
Like in revision 38569.


Agreed, that's better.

PS. Notice that my 1st email came from <gisle.vanem@xxxxxxxxx> and took
approx. 6 hours to get on this list. Waiting for what? My normal address (the one
I subscribed from and the one I reply from now) is <gvanem@xxxxxxxxxxxx>.
So it seems Mailman doesn't care so much about the address, but rather my name.
Anyone can subscribe and claim to be me. Doesn't sound correct.

--gv