Wireshark-dev: Re: [Wireshark-dev] Permanent Bytes/Packets handling enhancement in NetFlowV9/IP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Wed, 06 Apr 2011 07:40:53 +0200
Hi,
This would normally have to go through Bugzilla, so to better track and comment on patches. This patch for instance lacks line numbers. 

--- epan/dissectors/packet-netflow.c    (revision 36487)
+++ epan/dissectors/packet-netflow.c    (working copy)
@@ -%ld,%ld +%ld,%ld @@
 static int      hf_cflow_ipv6_exthdr            = -1;

So I'm wondering what diff tool you are using?

Thanks,
Jaap

On 04/06/2011 06:55 AM, Motonori Shindo wrote:

Hi,

Current NetFlow V9/IPFIX dissector treats IN_BYTES (IE=1) and
IN_PERMANENT_BYTES (IE=85) exactly in the same way. The same applies
to IN_PKTS (IE=2) and IN_PERMANENT_PKTS (IE=86). However,
IN_BYTES/IN_PKTS and IN_PERMANENT_BYTES/IN_PERMANENT_PKTS have
different semantics so they should be distinguishable when they are
displayed or specified in a filter. Please find attached the patch
which does that.

Regards,

---
Motonori Shindo