Wireshark-dev: Re: [Wireshark-dev] reduce the size of packet_info
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>
Date: Fri, 21 May 2010 22:10:27 +0200
Hi,

On Fri, May 21, 2010 at 10:52:50PM +0300, Kaul wrote:
> I've just looked at packet_info structure (epan/packet_info.h) and it's huge
> - everybody keeps something there.
> 1. I wonder how many times its allocated/de-allocated in a capture -
> reducing its size (and perhaps creating a pool of pinfo's) might help in
> performance. 

> I suspect we have 1 per packet, right? For big captures, it
> would cost in a lot of memory allocations.

I think you mistook packet_info struct, with frame_data one.

If we speaking about packet_info, it's usually allocated on stack,
very rarely on heap (greping after epan_dissect_new give me one hit)

Cheers.