Wireshark-dev: Re: [Wireshark-dev] preliminary code submission
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>
Date: Wed, 3 Feb 2010 19:19:01 +0100
Hi,

On Wed, Feb 03, 2010 at 01:05:32PM -0500, Brian Oleksa wrote:
> Jakub
>
> Thanks for this feedback. It is always good to have an extra set of eyes :-)

You missunderstood my comment about check_col()

instead of:
    if (check_col(pinfo->cinfo, COL_PROTOCOL))
        col_set_str(pinfo->cinfo, COL_PROTOCOL, PROTO_TAG_HELEN);         
                                
    if (check_col(pinfo->cinfo, COL_INFO))
        col_clear(pinfo->cinfo, COL_INFO);

Just write:
	col_set_str(pinfo->cinfo, COL_PROTOCOL, PROTO_TAG_HELEN);         
        col_clear(pinfo->cinfo, COL_INFO);

> gfloat latitude;
> latitude = tvb_get_ntohieee_float(tvb,offset);
>
> Why do you think this variable is not being used..??

Well because it's not used :) What is used for?

And one more thing...

You declare: ett_helen_ipv6, ett_helen_nos, ...
I believe you need only ett_helen from ett_*

Cheers.