Wireshark · Wireshark-dev: Re: [Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

[Gerasimos Dimitriadis <gedimitr@xxxxxxxxx>]

Thank you for your help Jakub and Bill, just committed 31662 following
your advice.

2010/1/25 Bill Meier <wmeier@xxxxxxxxxxx>:
> Jakub Zawadzki wrote:
>> Hi,
>>
>> On Mon, Jan 25, 2010 at 10:52:55AM +0200, Gerasimos Dimitriadis wrote:
>>> These two functions were defined in epan/column.c. Because I am not
>>> familiar with nmake, does this mean that column.c should be somehow
>>> marked for linking to libui.lib? Or do you think that it would be
>>> better to just move these 2 functions to another source file?
>>
>>
>> I think you need to add g_strdup_escape_underscore to libwireshark.def
>
> Correct....
>
>
> May I also suggest that the name should be changed to not use g_ as the
> initial part of the name.
>
> g_... is the namespace for GLib functions.
>
>
> (I'm not sure as the best source file for this and as to to a good name:
> ws_strdup... ??)
>
>
> Bill
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>