Wireshark · Wireshark-dev: Re: [Wireshark-dev] Dissector bug

["Maynard, Chris" <Christopher.Maynard@xxxxxxxxx>]

I ran checkhf.pl on packet-dash.c, but it didn't pick up the duplicates,
only the following:
Unused entry: ../../packet-dash.c, hf_description_len
Unused entry: ../../packet-dash.c, hf_oqtp_reserved
Unused entry: ../../packet-dash.c, hf_reserved_bits

However, I also just ran checkAPIs.pl on it, which found the following,
more egregious problems:
Warning: ../../packet-dash.c does not have an SVN Id tag.
Error: Found C++ style comments in ../../packet-dash.c
Error: ../../packet-dash.c                : Not terminated: value_string
group_type_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
group_sub_type_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
primary_assets_flag_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
asset_type_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
direction_field_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
sub_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
ippv_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
oppv_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
request_satisfied_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
no_extended_pd_syntax_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
sort_order_type_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
no_locator_flag_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
search_type_coding[]
Error: ../../packet-dash.c                : Not terminated: value_string
asset_types_coding[]
Error: Found prohibited APIs in ../../packet-dash.c: malloc,free

- Chris

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Joerg Mayer
Sent: Friday, January 08, 2010 11:34 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Dissector bug

On Fri, Jan 08, 2010 at 11:39:04AM +0530, Rach, Darshan wrote:
> I am getting the following error:
> [Dissector bug, protocol DASH: proto.c:2457: failed assertion
"(guint)hfindex < gpa_hfinfo.len"]
> 
> My code looks like this:
> 
> static gint hf_epg_info_bits_len = -1;
> 
> {&hf_epg_info_bits_len,
> {"EPG Info Bits Length","oqtp.epg_info_bits_len",FT_UINT8,
BASE_DEC,NULL, 0x0,
> "EPG Info Bits Length", HFILL}},
> 
> epg_info_bits_len = ((tvb_get_guint8(next_tvb, packet_field_offset)) &
0xf);
> proto_tree_add_uint(sub_tree, hf_epg_info_bits_len, next_tvb,
packet_field_offset, 1, epg_info_bits_len);
> packet_field_offset += 1;

Had similar problems of a similar type.  Please run tolls/checkhf.pl on
your dissector source.

 Ciao
        Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
________________________________________________________________________
___
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and 
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.